fix(Quiz) Don't highlight stroke when setting "showHintAfterMisses" to false

chanind / hanzi-writer

Chinese character stroke order animations and practice quizzes

https://hanziwriter.org

MIT License

3.55k stars 555 forks source link

fix(Quiz) Don't highlight stroke when setting "showHintAfterMisses" to false #187

Closed jamsch closed 4 years ago

jamsch commented 4 years ago

The docs mention in multiple places that setting "showHintAfterMisses" to false will disable hint stroke highlighting. This isn't the case and instead highlights after every mistake. This commit fixes the issue.

chanind commented 4 years ago

Really good catch! Could you add a test for this too?

jamsch commented 4 years ago

All good, I've added the test

chanind commented 4 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: