search

chanind / hanzi-writer

Chinese character stroke order animations and practice quizzes
https://hanziwriter.org
MIT License
3.48k stars 542 forks source link

fix: urlIdRef return string without url #216

Closed cqiangcode closed 3 years ago

chanind commented 3 years ago

This is how Hanzi Writer used to work, but this code has a bug that breaks in safari. More info here: https://talk.observablehq.com/t/hanzi-writer-renders-incorrectly-inside-an-observable-notebook-on-a-mobile-browser/1898. Could you explain what problem this PR is designed to solve?

cqiangcode commented 3 years ago

This is how Hanzi Writer used to work, but this code has a bug that breaks in safari. More info here: https://talk.observablehq.com/t/hanzi-writer-renders-incorrectly-inside-an-observable-notebook-on-a-mobile-browser/1898. Could you explain what problem this PR is designed to solve?

url of clip-path that containes '(' or ')' can not render correctly 💔

chanind commented 3 years ago

This should be fixed in 3.0.2. Thanks for finding this!