fix: prevent possible delay page scrolling marking touch listeners as passive

chanind / hanzi-writer

Chinese character stroke order animations and practice quizzes

https://hanziwriter.org

MIT License

3.44k stars 534 forks source link

fix: prevent possible delay page scrolling marking touch listeners as passive #274

Closed alelapi closed 2 years ago

alelapi commented 2 years ago

Lighthouse passive event listener audit fails (https://web.dev/uses-passive-event-listeners/?utm_source=lighthouse&utm_medium=lr#how-the-lighthouse-passive-event-listener-audit-fails) Lighthouse flags event listeners that may delay page scrolling.

Improved scrolling performance by adding a passive flag to every event listener that Lighthouse identified.

taktran commented 1 year ago

Hi @alelapi , I'm wondering whey this issue was closed? I'm seeing a similar warning

alelapi commented 1 year ago

hi @taktran , I actually closed the PR because doesn't fix the issue and I hadn't time to fix it, but the issue is still there, you are right. Please open an issue if you want to track it