chanind / hanzi-writer

Chinese character stroke order animations and practice quizzes
https://hanziwriter.org
MIT License
3.44k stars 534 forks source link

quiz mode: if I made a mistake 2 times, I'd like the stroke to be drawn for me #289

Closed ganqqwerty closed 1 year ago

ganqqwerty commented 1 year ago

I see that I have access to the writer object from onMistake callback. However, I did not understand if it's possible to command the writer to count my mistake as non-mistake and draw the stroke properly.

The problem that I'm solving is this: some strokes are hard to get right, so the user spends a lot of time trying to be precise, drawing the stroke again and again. I counted that it takes 1.5 - 3 times more to draw a kanji using this strategy than when the stroke is autodrawn after a couple of attempts. When we talk about 100 reviews a day, this is a difference between 20 min of study and a full hour, every day.

chanind commented 1 year ago

This sounds like a great feature request! I can see how this would be useful. If I understand correctly, you'd like a setting for quizzes where you could say something like: writer.quiz({ markStrokeCorrectAfterAttempts: 2 });?

ganqqwerty commented 1 year ago

yes, something like that would be great

chanind commented 1 year ago

I also wonder if this is a sign that the stroke grading for some strokes is too strict or could be improved. Are there any particular characters or stroke types you see this happen on?

chanind commented 1 year ago

:tada: This issue has been resolved in version 3.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ganqqwerty commented 1 year ago

I also wonder if this is a sign that the stroke grading for some strokes is too strict or could be improved. Are there any particular characters or stroke types you see this happen on?

I would list two types of strokes where the system is failing more often: