search

chanind / hanzi-writer

Chinese character stroke order animations and practice quizzes
https://hanziwriter.org
MIT License
3.44k stars 534 forks source link

feat: Added skipStrokeQuiz #317

Closed vherrmann closed 2 months ago

vherrmann commented 2 months ago

This feature adds a function skipStrokeQuiz, that can be used while in a quiz to skip a stroke. This is useful for e.g. 圖, since hanzi writer has a hard time recognizing the short strike under the upper inner box of clipboard

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.43%. Comparing base (4ec4eda) to head (63c209a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #317 +/- ## ========================================== + Coverage 96.41% 96.43% +0.01% ========================================== Files 32 32 Lines 1144 1149 +5 Branches 212 214 +2 ========================================== + Hits 1103 1108 +5 Misses 37 37 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chanind commented 2 months ago

Thanks for contributing this! I tweaked the API slightly so it's called skipQuizStroke, and added test coverage.

chanind commented 2 months ago

:tada: This PR is included in version 3.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vherrmann commented 2 months ago

Nice! Thanks for the quick response (and the project in general)