search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Handle failing push #129

Closed alter2000 closed 2 years ago

alter2000 commented 2 years ago

When a force push fails, as far as I could tell it's not a problem with neither the repository state nor with git, so this PR makes failing force pushes be handled as any other rejected push. There's no tests whatsoever for just the function executing git commands and I haven't yet added any, but from what I tried manually breaking it nothing happened.

I'm open to add some tests for runGit specifically but I'd prefer getting started with other tests first. Please let me know what I can do better.

alter2000 commented 2 years ago

@OpsBotPrime merge on friday

OpsBotPrime commented 2 years ago

Pull request approved for merge by @alter2000, rebasing now.

OpsBotPrime commented 2 years ago

Rebased as 5d548cb195fbd75e6c83ce21a0abad7d581d8616, waiting for CI …