search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Test comments looping back from GitHub #139

Closed rudymatela closed 2 years ago

rudymatela commented 2 years ago

Test comments looping back from GitHub.

Whenever Hoff posts a comment on GitHub, it is notified back by GitHub that that a new comment has been posted. This makes it so that a test now has this behaviour.

This would have detected the issue with v0.25.7 where Hoff got stuck in an infinite loop. Please see #140 which applies these tests on top of the buggy version.

rudymatela commented 2 years ago

@alex-mckenna @ReinierMaas, thanks for the review.

@OpsBotPrime merge on Friday

OpsBotPrime commented 2 years ago

Pull request approved for merge by @rudymatela, rebasing now.

OpsBotPrime commented 2 years ago

Rebased as 9af294a0c387945043799f5a099415f5214c43ec, waiting for CI …