channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Split BuildPending into BuildStarted. #146

Closed rudymatela closed 2 years ago

rudymatela commented 2 years ago

In preparation for: #137. Closes: #77.

This changes how the status is represented to something more explicit and descriptive:

BuildPending Nothing                     -> BuildPending
BuildPending (Just "ci.example.com/...") -> BuildStarted "ci.example.com/..."

This will make the change in #137 much nicer and simpler.

I checked and this does not affect the parsing of status files during an upgrade.

There are two other somewhat unrelated changes explained below.

Build status wording

... and slightly change the build status comment wording to "CI job started."

Rendering Status + Commit Hash on the web interface

... and change web rendering of CI jobs. Besides the link to the CI, we also now include a link to the commit in GitHub.

Before:

old

After:

new

The icons are clickable and so are the commit hashes:

Even though the heading already identifies the build status, this makes it so that the link to CI is somewhat consistent with GitHub UX: gh-interface

~Having "View in CI | e711b80" looked a bit weird now that the commit hash is present.~ Not applicable anymore.

rudymatela commented 2 years ago

UI as of https://github.com/channable/hoff/pull/146/commits/82ecce5f6d49de91cc74ab45deeddf0dd56666d2:

intermediary

rudymatela commented 2 years ago

UI as of https://github.com/channable/hoff/pull/146/commits/febcaa2656517385c9d47f2209e492c0f2423cc2: new

The PR description has been updated with this.

... and here's how it looks before the build link arrives:

building-no-ci

rudymatela commented 2 years ago

@OpsBotPrime merge yourself please and thank you.

OpsBotPrime commented 2 years ago

Pull request approved for merge by @rudymatela, rebasing now.

OpsBotPrime commented 2 years ago

Rebased as 12b01d17647d70d2bd7232d76477543725ca0812, waiting for CI …

OpsBotPrime commented 2 years ago

Waiting on CI job: https://channable.semaphoreci.com/workflows/0e3caf28-bbf2-4123-8833-c881c2d1cd20?pipeline_id=204c5b5c-da86-4ca0-ae08-9c9de45cfb4b