search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Log repository name beside PR number #171

Closed rudymatela closed 2 years ago

rudymatela commented 2 years ago

Here are three log lines from Hoff:

Aug 23 09:19:00 hoff hoff[12766]: [Info] Posted comment on 1234: Pull request approved for merge by @someone, rebasing now.
Aug 23 09:19:19 hoff hoff[12766]: [Info] Posted comment on 1234: Rebased as 0123abcdef0123456789abcdef0123456789abcd, waiting for CI …
Aug 23 09:19:23 hoff hoff[12766]: [Info] Posted comment on 1234: [CI job](https://....semaphoreci.com/workflows/00000000-0000-0000-0000-000000000000) started.

We know that they concern PR #1234, but we do not know which project/repository they refer to! They should read:

Aug 23 09:19:00 hoff hoff[12766]: [Info] Posted comment on repository#1234: Pull request approved for merge by @someone, rebasing now.
Aug 23 09:19:19 hoff hoff[12766]: [Info] Posted comment on repository#1234: Rebased as 0123abcdef0123456789abcdef0123456789abcd, waiting for CI …
Aug 23 09:19:23 hoff hoff[12766]: [Info] Posted comment on repository#1234: [CI job](https://....semaphoreci.com/workflows/00000000-0000-0000-0000-000000000000) started.

Here, the "Posted comment" logging was chosen as an example. We should do this for all types of Hoff messages that include pull request ids.

rudymatela commented 2 years ago

This was closed by #182.