channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Only unintegrate after closing unfailed pull requests #184

Closed rudymatela closed 2 years ago

rudymatela commented 2 years ago

~There was an instance of a rebase being triggered by a PR closure. This should not happen:~

PRs 19 and 36 were closed in that order at: 13:25:59 and 13:26:00. Seemingly, closure of PR 36 caused it to be rebased, but actually that was caused by the closure of 19:

rebase-after-closing

There is still a bug here: the closure of 19 should not have triggered a rebase of 36 as it had already failed. The handlePullRequestClosure logic has to be fixed. We should only unintegrateAfter when the PR being closed is unfailedIntegrated.

(Thanks to @Gijsvs for reporting.)

TODO

rudymatela commented 2 years ago

Here's how to extract the relevant logs:

journalctl -S "2022-09-02 13:23" -U "2022-09-02 13:28" -uhoff >closure-triggering-rebase.log