search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Add Prometheus-readable metrics endpoint #194

Closed diegodiv closed 1 year ago

diegodiv commented 1 year ago

Fixes part of https://github.com/channable/hoff/issues/99 by showing Prometheus-readable metrics on a configurable port, only showing one metric (number of PRs merged) at the moment. Other metrics will be easier to add now, but they should be described in new issues, in more specific detail, when the need arises.

diegodiv commented 1 year ago

I don't read Haskell very well so I can't comment too much, but I have one suggestion

Right now we have a single counter for the number of PRs merged. This is not that helpful if you have many projects in a single instance like we do. Perhaps we could add a project label to the counter and track the metric by project?

Sorry for the lack of clarity, that's what it already does!

diegodiv commented 1 year ago

@OpsBotPrime merge

OpsBotPrime commented 1 year ago

Pull request approved for merge by @DiegoDiverio, rebasing now.

OpsBotPrime commented 1 year ago

Rebased as 7e9026c41db872a8de2232bfc5a77618ddc82e60, waiting for CI …

OpsBotPrime commented 1 year ago

CI job :yellow_circle: started.