search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Do not print entire state before and after all ops #218

Closed FPtje closed 1 year ago

FPtje commented 1 year ago

This state is very useful for debugging, but in production it becomes extremely hard to follow the logs. It's better to add debug prints to debug specific situations.

This becomes specifically problematic when Hoff follows repos with many open pull requests. Every time anything happens, it will print all of those pull requests both before and after the action. On my device, this is multiple screens full of state. That makes the Hoff log completely unreadable in practice.

There is a small loss in not being able to debug a problem in hindsight in production, but with the log volume, I don't think it was realistically possible anyway.

FPtje commented 1 year ago

@OpsBotPrime merge

OpsBotPrime commented 1 year ago

Pull request approved for merge by @FPtje, rebasing now.

OpsBotPrime commented 1 year ago

Rebased as 174e285b6f2d19c9f94013bb8dc4032ed10420b4, waiting for CI …

OpsBotPrime commented 1 year ago

CI job :yellow_circle: started.