search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

Add missing 'promotionTimeout' field also to doc/example-dev-config.json #247

Closed Qqwy closed 10 months ago

Qqwy commented 10 months ago

When currently following the 'Running as a developer' steps in the README, Hoff does not start but instead throws the following error:

$ cabal run hoff config.json 
Starting Hoff v0.32.2
Config file: config.json
Read-only: False
Failed to parse configuration file 'config.json'.
Error in $: parsing Configuration.Configuration(Configuration) failed, key "promotionTimeout" not found

Seems that the promotionTimeout field exists in package/example-config.json but it is still missing in doc/example-dev-config.json.

This PR copies the missing field to doc/example-dev-config.json to make sure building-and-running Just Works :tm: for other devs in the future.

Qqwy commented 10 months ago

@OpsBotPrime merge

OpsBotPrime commented 10 months ago

Pull request approved for merge by @Qqwy, rebasing now.

OpsBotPrime commented 10 months ago

Rebased as 2609a21a5bcfe841b4f40224353a06592b4f70bc, waiting for CI …

OpsBotPrime commented 10 months ago

CI job :yellow_circle: started.