search

channable / hoff

A gatekeeper for your commits
Apache License 2.0
41 stars 3 forks source link

feedbackOnStatus: Use format for everything #273

Closed isomorpheme closed 4 weeks ago

isomorpheme commented 1 month ago

Depends on #272 (just because that function got touched there; rebasing later would be a pain).

robbert-vdh commented 1 month ago

Just FYI, Text.Format is a big footgun, and I'd avoid it for anything somehwat mission critical (or in general). If the length o the list doesn't match the number of placeholders, then this call will diverge, which could end up taking the entire service down.

isomorpheme commented 1 month ago

Just FYI, Text.Format is a big footgun, and I'd avoid it for anything somehwat mission critical (or in general). If the length o the list doesn't match the number of placeholders, then this call will diverge, which could end up taking the entire service down.

Thanks for pointing this out! I've created #275 to completely get rid of it then.

isomorpheme commented 4 weeks ago

@OpsBotPrime merge

OpsBotPrime commented 4 weeks ago

Pull request approved for merge by @isomorpheme, rebasing now.

OpsBotPrime commented 4 weeks ago

Failed to rebase, please rebase manually using

git fetch && git rebase --interactive --autosquash origin/master refactor-use-format
isomorpheme commented 4 weeks ago

@OpsBotPrime merge

OpsBotPrime commented 4 weeks ago

Pull request approved for merge by @isomorpheme, rebasing now.

OpsBotPrime commented 4 weeks ago

Rebased as 82ebfd6dc13005fd8556167221990657730f94ee, waiting for CI …

OpsBotPrime commented 4 weeks ago

CI job :yellow_circle: started.