channel-io / bezier-react

React components library that implements Bezier design system.
https://main--62bead1508281287d3c94d25.chromatic.com
Apache License 2.0
184 stars 46 forks source link

Revert babel-styled-components plugin #1100

Closed leejiwoo2002 closed 1 year ago

leejiwoo2002 commented 1 year ago

Self Checklist

Summary

This reverts commit 650d31bdf0b9ff64bebac872378ec18799c3b468. (babel.config.js)

Details

This setting causes a hydration error during the server-side rendering process. So we have to revert.

changeset-bot[bot] commented 1 year ago

πŸ¦‹ Changeset detected

Latest commit: 8471eb02d072072fdad39f7e5095c129418d2342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Patch | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

aooen commented 1 year ago

이거 μ—†μ• λŠ” μ΄μœ κ°€ λ­”κ°€μš”?~

leejiwoo2002 commented 1 year ago

@aooen SSR ν™˜κ²½μ—μ„œ hydration μ—λŸ¬λ₯Ό λ°œμƒμ‹œν‚€λŠ” 였λ₯˜κ°€ μžˆλŠ”κ²ƒμœΌλ‘œ λ³΄μž…λ‹ˆλ‹€ ν™ˆνŽ˜μ΄μ§€μͺ½μ— λ¬Έμ œκ°€ λ°œμƒν•˜μ—¬ μ—λ“œμ™€ νŽ˜μ–΄ ν”„λ‘œκ·Έλž˜λ°μ„ μ§„ν–‰ν–ˆκ³ , μ†ŒμŠ€μ—λŠ” λ¬Έμ œκ°€ μ—†μŒ + μ‚¬μš©μ²˜μ—μ„œλ„ 별닀λ₯Έ μ„€μ • μ—†μŒ + 였λ₯˜κ°€ λ°œμƒν•œ μ‹œμ  μΆ”μ ν•˜μ—¬ 확인해 λ³Έ λ°” μœ„ 섀정을 μ›λ³΅ν•˜μž μ—λŸ¬κ°€ μ‚¬λΌμ‘ŒμŒμ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€

github-actions[bot] commented 1 year ago

Chromatic Report

πŸš€ Congratulations! Your build was successful!

codecov[bot] commented 1 year ago

Codecov Report

Base: 72.61% // Head: 72.61% // No change to project coverage :thumbsup:

Coverage data is based on head (8471eb0) compared to base (b509000). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next-v1 #1100 +/- ## ======================================== Coverage 72.61% 72.61% ======================================== Files 237 237 Lines 3137 3137 Branches 853 853 ======================================== Hits 2278 2278 Misses 728 728 Partials 131 131 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=channel-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=channel-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sungik-choi commented 1 year ago

Rollup 섀정도 원볡해야할 κ±° κ°™μŠ΅λ‹ˆλ‹€~!

leejiwoo2002 commented 1 year ago

Revertν•œ 뒀에 PR λ‹€μ‹œ μž‘μ„±ν•˜κ² μŠ΅λ‹ˆλ‹€..!

aooen commented 1 year ago

https://github.com/styled-components/babel-plugin-styled-components/issues/351#issuecomment-1002779260 κ΄€λ ¨ 이슈 같은데 쑰금만 더 μ°Ύμ•„λ³Όκ²Œμš”