Tanney-102 commented 6 months ago

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[ ] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

Modal에서 사용되는 radix overlay의 padding은 '40px 0'으로 고정되어 있었습니다.
미트 새 창 프로덕트에서 해당 padding을 40px보다 더 작게 주어야 할 니즈가 생겨 이를 위한 prop을 추가합니다.

Details

MdoalContent에서 collisionPadding prop을 받도록 합니다. (Radix Popper 참고)
- collisionPadding은 숫자 혹은 각 사이드별 크기를 담은 객체입니다.
```
type CollisionPadding = number | Partial<Record<'top' | 'right' | 'bottom' | 'left', number>>
```
collisionPadding을 실제 padding string으로 변환해 overlay에 주입합니다.

Breaking change? (Yes/No)

no

References

Radix Popper

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 3a990f29a7442bd874a12ee9e7afe68781aec87c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Minor | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 months ago

Chromatic Report

🚀 Congratulations! Your build was successful!

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (410c21a) 87.45% compared to head (3a990f2) 87.43%.

Files	Patch %	Lines
...react/src/components/Modals/Modal/ModalContent.tsx	75.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1747 +/- ## ========================================== - Coverage 87.45% 87.43% -0.03% ========================================== Files 281 281 Lines 3931 3938 +7 Branches 822 824 +2 ========================================== + Hits 3438 3443 +5 - Misses 421 423 +2 Partials 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sungik-choi commented 6 months ago

@Tanney-102 main 브랜치 최신화 이후 머지해주시면 될 거 같습니다 👍