Dogdriip commented 1 month ago

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[x] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Avatar, Emoji 컴포넌트의 aria-label 속성을 aria-description 속성으로 대체합니다.

Details

aria-label 속성은 Interactive한 element에 부여하는 것이 의도입니다.

Note: aria-label is intended for interactive elements or for elements made interactive via other ARIA declarations when there's no visible text in the DOM to serve as a label.

Note: While aria-label can be used on any element that can have an accessible name, in practice however, it is supported only on interactive elements, widgets, landmarks, images, and iframes.

Breaking change? (Yes/No)

No.

References

channeltalk[bot] commented 1 month ago

https://desk.channel.io/#/channels/1/team_chats/groups/1237/66418ceabe6153c903f5

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 510ef3bf7aefc749591e11989807668b29b69d3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Patch | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.10%. Comparing base (621b3eb) to head (510ef3b). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2217 +/- ## ========================================== - Coverage 85.61% 85.10% -0.51% ========================================== Files 132 133 +1 Lines 2843 2860 +17 Branches 841 851 +10 ========================================== Hits 2434 2434 - Misses 404 421 +17 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Chromatic Report

🚀 Congratulations! Your build was successful!

yangwooseong commented 1 month ago

혹시 첨부하신 스크린샷은 어디서 볼 수 있었나요?? Emoji 컴포넌트에서도 div 에 aria-label 을 사용하고 있어서 여기도 바꿔주시면 좋을것같습니다!

channel-io / bezier-react

Replace `aria-label` of non-interactive elements #2217