channel-io / bezier-react

React components library that implements Bezier design system.

https://main--62bead1508281287d3c94d25.chromatic.com

Apache License 2.0

231 stars 47 forks source link

Fix `size` props of `AlphaLoader` component to be required #2458

Closed yangwooseong closed 1 month ago

yangwooseong commented 1 month ago

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[x] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

None

Summary

AlphaLoader size 속성의 초기값이 없기 때문에 optional 이 아닌 required로 수정합니다.

Details

생략

Breaking change? (Yes/No)

References

컴포넌트 스펙(internal)

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: df21648507409fa150896d2c7c04e4f8fef21e02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Patch | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

channeltalk[bot] commented 1 month ago

https://desk.channel.io/#/channels/1/team_chats/groups/1237/671702b08721ecce954d

github-actions[bot] commented 1 month ago

Chromatic Report

🚀 Congratulations! Your build was successful!

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.39%. Comparing base (8bc375c) to head (df21648). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2458 +/- ## ======================================= Coverage 83.39% 83.39% ======================================= Files 141 141 Lines 2939 2939 Branches 908 908 ======================================= Hits 2451 2451 Misses 458 458 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yangwooseong commented 1 month ago

타입 체크 터지는 부분 확인해주세요!

버튼에서 쓰고 있는 곳이 있어서 size 속성을 채웠습니다. 다만 버튼 스펙상으로는 로더가 아이콘 크기로 정해져서 주석을 추가했습니다