channel-io / bezier-react

React components library that implements Bezier design system.

https://main--62bead1508281287d3c94d25.chromatic.com

Apache License 2.0

231 stars 47 forks source link

Fix bug of "+1" emoji not rendering #2470

Closed yangwooseong closed 3 weeks ago

yangwooseong commented 3 weeks ago

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[x] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #2449

Summary

"+1"(👍) 이모지가 렌더링 되지 않은 버그를 수정합니다.

Details

emoji 이름으로 부터 url 을 계산할 때 인코딩 처리가 누락되어 있던 것이 원인이었습니다.

Breaking change? (Yes/No)

References

None

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 948b503308c9d2fed7fac886b61585f9bc7e4a01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Patch | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

channeltalk[bot] commented 3 weeks ago

https://desk.channel.io/#/channels/1/team_chats/groups/1237/67218917aac1fc64060b

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.28%. Comparing base (11c6038) to head (8b94ff2). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2470 +/- ## ======================================= Coverage 83.28% 83.28% ======================================= Files 141 141 Lines 2943 2943 Branches 912 899 -13 ======================================= Hits 2451 2451 Misses 487 487 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Chromatic Report

🚀 Congratulations! Your build was successful!