channel-io / bezier-react

React components library that implements Bezier design system.
https://main--62bead1508281287d3c94d25.chromatic.com
Apache License 2.0
185 stars 46 forks source link

feat(text): add size17 option to Text typography #913

Closed yangwooseong closed 1 year ago

yangwooseong commented 1 year ago

Self Checklist

Related Issue

Fixes #912

Summary

This PR adds Size17 option to Typography

Breaking change or not (Yes/No)

No

References

Figma

changeset-bot[bot] commented 1 year ago

πŸ¦‹ Changeset detected

Latest commit: 2038b4676b18288640f0e5014cbb0c1391084813

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Minor | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #913 (2038b46) into next-v1 (62a4f71) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v1     #913      +/-   ##
===========================================
+ Coverage    70.86%   70.87%   +0.01%     
===========================================
  Files          204      204              
  Lines         2883     2884       +1     
  Branches       797      797              
===========================================
+ Hits          2043     2044       +1     
  Misses         722      722              
  Partials       118      118              
Impacted Files Coverage Ξ”
packages/bezier-react/src/foundation/Typography.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Chromatic Report

πŸš€ Congratulations! Your build was successful!

sungik-choi commented 1 year ago

ν…ŒμŠ€νŠΈλž‘ μŠ€ν† λ¦¬λΆ λ¬Έμ„œ μž‘μ„±μ€ μ²΄ν¬λ¦¬μŠ€νŠΈμ—μ„œ μ œμ™Έν•΄μ•Όν• κ²ƒ κ°™μ•„μš”.

μ˜΅μ…”λ„λ‘œ λ‘λŠ” 건 μ–΄λ–¨κΉŒμš”? μ²΄ν¬λ¦¬μŠ€νŠΈκ°€ 있음으둜써 ν•„μš”μ„±μ„ ν™˜κΈ°μ‹œμΌœμ€€λ‹€κ³  μƒκ°ν•΄μ„œμš”

Seolhun commented 1 year ago

ν…ŒμŠ€νŠΈλž‘ μŠ€ν† λ¦¬λΆ λ¬Έμ„œ μž‘μ„±μ€ μ²΄ν¬λ¦¬μŠ€νŠΈμ—μ„œ μ œμ™Έν•΄μ•Όν• κ²ƒ κ°™μ•„μš”.

μ˜΅μ…”λ„λ‘œ λ‘λŠ” 건 μ–΄λ–¨κΉŒμš”? μ²΄ν¬λ¦¬μŠ€νŠΈκ°€ 있음으둜써 ν•„μš”μ„±μ„ ν™˜κΈ°μ‹œμΌœμ€€λ‹€κ³  μƒκ°ν•΄μ„œμš”

μ œμ™Έκ°€ ν…œν”Œλ¦Ώμ—μ„œ μ œμ™Έκ°€ μ•„λ‹ˆλΌ, ν˜„μž¬ μž‘μ—…λ‚΄μš©μ—μ„œ 체크가 ν•΄μ œ λ˜μ–΄μ•Ό ν•œλ‹€μž…λ‹ˆλ‹€.

sungik-choi commented 1 year ago

ν…ŒμŠ€νŠΈλž‘ μŠ€ν† λ¦¬λΆ λ¬Έμ„œ μž‘μ„±μ€ μ²΄ν¬λ¦¬μŠ€νŠΈμ—μ„œ μ œμ™Έν•΄μ•Όν• κ²ƒ κ°™μ•„μš”.

μ˜΅μ…”λ„λ‘œ λ‘λŠ” 건 μ–΄λ–¨κΉŒμš”? μ²΄ν¬λ¦¬μŠ€νŠΈκ°€ 있음으둜써 ν•„μš”μ„±μ„ ν™˜κΈ°μ‹œμΌœμ€€λ‹€κ³  μƒκ°ν•΄μ„œμš”

μ œμ™Έκ°€ ν…œν”Œλ¦Ώμ—μ„œ μ œμ™Έκ°€ μ•„λ‹ˆλΌ, ν˜„μž¬ μž‘μ—…λ‚΄μš©μ—μ„œ 체크가 ν•΄μ œ λ˜μ–΄μ•Ό ν•œλ‹€μž…λ‹ˆλ‹€.

μ•„ μ΄ν•΄ν–ˆμŠ΅λ‹ˆλ‹€. μž‘μ—…λ‚΄μ—­μ— 맞게 체크가 λ˜μ–΄μžˆμ„ 거라고 μƒμ •ν•˜κ³  λ‹΅ν–ˆμ—ˆλ„€μš”.