Closed gump59 closed 8 years ago
getDimensions(tableName: string, globalSecondaryIndexName: ?string): Dimension[] { if (globalSecondaryIndexName) { return [ { Name: 'TableName', Value: tableName}, { Name: 'GlobalSecondaryIndex', Value: globalSecondaryIndexName} ]; }
return [ { Name: 'TableName', Value: tableName} ];
} }
Name for the GSI Dimension is slightly off, should be GlobalSecondaryIndexName instead of GlobalSecondaryIndex. I haven't merged in your latest, but this bit is unchanged, and it was fixed when I changed it in my fork.
I've made the change, many thanks for raising this.
getDimensions(tableName: string, globalSecondaryIndexName: ?string): Dimension[] { if (globalSecondaryIndexName) { return [ { Name: 'TableName', Value: tableName}, { Name: 'GlobalSecondaryIndex', Value: globalSecondaryIndexName} ]; }
} }
Name for the GSI Dimension is slightly off, should be GlobalSecondaryIndexName instead of GlobalSecondaryIndex. I haven't merged in your latest, but this bit is unchanged, and it was fixed when I changed it in my fork.