channl / dynamodb-lambda-autoscale

Autoscale DynamoDB provisioned capacity using Lambda
MIT License
313 stars 88 forks source link

GSI issue with CapacityCalculatorBase.js #19

Closed gump59 closed 8 years ago

gump59 commented 8 years ago

getDimensions(tableName: string, globalSecondaryIndexName: ?string): Dimension[] { if (globalSecondaryIndexName) { return [ { Name: 'TableName', Value: tableName}, { Name: 'GlobalSecondaryIndex', Value: globalSecondaryIndexName} ]; }

return [ { Name: 'TableName', Value: tableName} ];

} }

Name for the GSI Dimension is slightly off, should be GlobalSecondaryIndexName instead of GlobalSecondaryIndex. I haven't merged in your latest, but this bit is unchanged, and it was fixed when I changed it in my fork.

tmitchel2 commented 8 years ago

I've made the change, many thanks for raising this.