chantasaur / lightopenid

Automatically exported from code.google.com/p/lightopenid
0 stars 0 forks source link

ZendStudio gives warning #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi,

Yes, it's terribly minor (or even less), anyway I get a nice warning 
'assignment in condition' in the openid.php file at line 340 when working with 
ZendStudio:

"
$content = $this->request($url, 'GET');
if ($location = $this->htmlTag($content, 'meta', 'http-equiv', 
'X-XRDS-Location', 'value')) {
   $url = $this->build_url(parse_url($url), parse_url($location));
    continue;
       }
"

If you just replace it with something like this, ZendStudio is happy as well. 
Tnx!

"
$content = $this->request($url, 'GET');
$location = $this->htmlTag($content, 'meta', 'http-equiv', 'X-XRDS-Location', 
'value');
 if ($location=='') {
$url = $this->build_url(parse_url($url), parse_url($location));
 continue;
 }

Original issue reported on code.google.com by nielsba...@gmail.com on 21 Nov 2010 at 10:40

GoogleCodeExporter commented 8 years ago
Not really a problem with LightOpenID, but fixed anyway.

Original comment by mewp...@gmail.com on 22 Nov 2010 at 3:28