chanzuckerberg / ExpressionMatrix2

Software for exploration of gene expression data from single-cell RNA sequencing.
MIT License
28 stars 4 forks source link

Create cell set from meta data using exact match instead of regex #6

Closed paoloczi closed 6 years ago

paoloczi commented 6 years ago

Otherwise regex queries coming from the browser have to be escaped. Example: s = e.createCellSetUsingMetaData("s3{}".format(run), "Selection", "Astrocytes(HEPACAM)") → 0 matches s = e.createCellSetUsingMetaData("s3{}".format(run), "Selection", "Astrocytes(HEPACAM)") → 714 matches

paoloczi commented 6 years ago

I modified createCellSetUsingMetaData to allow either string matching or regular expression matching. This is done using an additional Boolean parameter, so this is an incompatible change.

Charlotte, please close this after verifying that it satisfies what you were asking for.

paoloczi commented 6 years ago

I am closing this issue under the assumption that the lack of comments means that the issue is fixed. Please reopen if this is not the case.