chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
78 stars 20 forks source link

Return warnings if some method parameters are invalid or otherwise ignored #1027

Open hthomas-czi opened 6 months ago

hthomas-czi commented 6 months ago

Visibility of system status is an important usability heuristic. We should communicate to users if the system deviates from their intention.

User Quote

if filtering with a cell type ontology label that was not present in the census, the query completes, but it silently drops the missing ontology terms. This should be verbose so that the user knows which terms were dropped.

ebezzi commented 5 months ago

This request is unclear. The users can check the existence of such terms themselves (e.g. by checking either the categories or unique values for an obs column) before issuing the query. Doing this static check as part of the API will incur into a performance hit and is not how the vast majority of the query systems work (including SQL).