chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
72 stars 19 forks source link

[builder] Add ClientResponseError to the builder managed exceptions #1126

Closed ebezzi closed 1 month ago

ebezzi commented 2 months ago

I'm assuming that the original idea is that ClientResponseError should be escalated since it's not a transient error (e.g. 404), but the recent failures suggest otherwise.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.12%. Comparing base (cb310b5) to head (cf06601). Report is 1 commits behind head on main.

Files Patch % Lines
...llxgene_census_builder/build_soma/source_assets.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1126 +/- ## ======================================= Coverage 91.12% 91.12% ======================================= Files 77 77 Lines 5857 5857 ======================================= Hits 5337 5337 Misses 520 520 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1126/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `91.12% <50.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.