search

chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
72 stars 19 forks source link

[python] Add get_obs #1151

Closed ivirshup closed 1 month ago

ivirshup commented 1 month ago

Fixes https://github.com/chanzuckerberg/cellxgene-census/issues/1037

TODO:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.67442% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.16%. Comparing base (e36addb) to head (f2db37f).

Files Patch % Lines
...lxgene_census/src/cellxgene_census/_get_anndata.py 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1151 +/- ## ========================================== + Coverage 91.12% 91.16% +0.04% ========================================== Files 77 77 Lines 5857 5896 +39 ========================================== + Hits 5337 5375 +38 - Misses 520 521 +1 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `91.16% <97.67%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prathapsridharan commented 1 month ago

get_obs and get_var to me seems consistent when put together with anndata related functions. And the same applies to helper functions needed in service of get_anndata, get_obs, get_var.

I think we can shift things around later if needed but for now this organization seems fine to me

ivirshup commented 1 month ago

Thanks for the catch! Applied your changes.