search

chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
72 stars 18 forks source link

[python] Relax pin: `tiledbsoma~=1.11.4` #1187

Closed ryan-williams closed 4 weeks ago

ryan-williams commented 4 weeks ago

While developing, local tiledbsoma installs get version numbers like 1.11.4.post0.dev3991933300. The tiledbsoma==1.11.4 pin in this repo errors when attempting to install alongside such a tiledbsoma, e.g. in arrayloader-benchmarks:

pip install -e cellxgene-census/api/python/cellxgene_census -e tiledb-soma/apis/python
# ERROR: Cannot install cellxgene-census==1.14.2.dev3+g5de4536.d20240606 and tiledbsoma 1.11.4.post0.dev3991933300 (from $PWD/tiledb-soma/apis/python) because these package versions have conflicting dependencies.
# 
# The conflict is caused by:
#     The user requested tiledbsoma 1.11.4.post0.dev3991933300 (from $PWD/tiledb-soma/apis/python)
#     cellxgene-census 1.14.2.dev3+g5de4536.d20240606 depends on tiledbsoma==1.11.4
# 
# To fix this you could try to:
# 1. loosen the range of package versions you've specified
# 2. remove package versions to allow pip attempt to solve the dependency conflict

tiledbsoma~=1.11.4 (equivalent to tiledbsoma>=1.11.4,<1.12.0) lets such local installs work, and doesn't have any downsides, afaict.

(factored out of #1169)

ryan-williams commented 4 weeks ago

Ah gtk, I hadn't noticed that (dfb20420eac1c51328c416b78ed6b77b99d9e2ca).

The Docker build GHA here failed with:

ERROR: invalid tag "/cellxgene-census-builder:823a27f": invalid reference format

after checking out SHA 823a27fdee1ab1389ec807c89aaf2d8258c94066 ("Merge https://github.com/chanzuckerberg/cellxgene-census/commit/5de45369b6195beb379f4426b8f0aad4fa6b7b02 into https://github.com/chanzuckerberg/cellxgene-census/commit/5fc72e2e57a889b851dc29815d23c541997d7629").

I'm guessing the issue is that I opened this PR from a branch in my fork. lmk if you want me to open a new one from a branch in this repo, or take some other action?

ebezzi commented 4 weeks ago

Ah gtk, I hadn't noticed that (dfb2042).

The Docker build GHA here failed with:

ERROR: invalid tag "/cellxgene-census-builder:823a27f": invalid reference format

after checking out SHA 823a27f ("Merge 5de4536 into 5fc72e2").

I'm guessing the issue is that I opened this PR from a branch in my fork. lmk if you want me to open a new one from a branch in this repo, or take some other action?

Yeah, that's a known issue. I will go ahead and merge this. Thanks again!