chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
72 stars 18 forks source link

[python] set user-agent #1193

Closed ivirshup closed 1 day ago

ivirshup commented 3 weeks ago

This PR sets a user agent on requests from the python api, addressing part of #997

Could do

Most of the typing problems are in the tests. I think there's very little value to adding more type info here, and it gets quite complicated since most of it is in fixtures. I don't think doing much more is worth it, so would like to ignore these.

Probably should do:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 92.09040% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (8d1e103) to head (3f5a42d). Report is 3 commits behind head on main.

Files Patch % Lines
...nsus/src/cellxgene_census/_testing/logger_proxy.py 42.10% 11 Missing :warning:
...i/python/cellxgene_census/tests/test_user_agent.py 98.55% 2 Missing :warning:
...hon/cellxgene_census/src/cellxgene_census/_util.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1193 +/- ## ========================================== + Coverage 91.11% 91.25% +0.13% ========================================== Files 77 79 +2 Lines 5923 6141 +218 ========================================== + Hits 5397 5604 +207 - Misses 526 537 +11 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1193/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1193/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `91.25% <92.09%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ivirshup commented 1 week ago

For test coverage on the logger_proxy.py file, that code isn't executed by the test process so I wouldn't expect coverage.