Closed ivirshup closed 1 day ago
Attention: Patch coverage is 92.09040%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 91.25%. Comparing base (
8d1e103
) to head (3f5a42d
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For test coverage on the logger_proxy.py
file, that code isn't executed by the test process so I wouldn't expect coverage.
This PR sets a user agent on requests from the python api, addressing part of #997
cellxgene-census-python/{VERSION}
CELLXGENE_CENSUS_USERAGENT
whose value will be added to the user agent if defined. This allows us to set the flag on internal systems and figure out internal vs external usage of the resource.test_user_agent
. This is the most complicated part.Could do
Most of the typing problems are in the tests. I think there's very little value to adding more type info here, and it gets quite complicated since most of it is in fixtures. I don't think doing much more is worth it, so would like to ignore these.
Probably should do:
.dev
for all of these). Idk what this should be.