chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
72 stars 18 forks source link

[python] fix mypy complaint in experimental/_embedding.py #1197

Closed mlin closed 2 weeks ago

mlin commented 2 weeks ago

This fixes a mypy error that arose spontaneously, probably due to a change in mypy or numpy. Seen in this CI run for my completely unrelated commit on main: https://github.com/chanzuckerberg/cellxgene-census/actions/runs/9558859502/job/26348249505#step:5:145

That commit is completely unrelated but fortunately I hit this problem while separately working on #1164 where I also put this fix.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.11%. Comparing base (ef51740) to head (0783f2b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1197 +/- ## ======================================= Coverage 91.11% 91.11% ======================================= Files 77 77 Lines 5922 5922 ======================================= Hits 5396 5396 Misses 526 526 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1197/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `91.11% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mlin commented 2 weeks ago

Whoever sees this first should merge it!!