chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
88 stars 22 forks source link

chore(docs): Add banner and newsletter signup (SCE-29) #1286

Closed kaloster closed 1 month ago

kaloster commented 2 months ago

Added back bottom banner and newsletter signup

Based on this reverted PR

Screenshot 2024-09-24 at 12 22 22 PM Screenshot 2024-09-24 at 12 22 10 PM
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.36%. Comparing base (dc4eb1f) to head (072f789). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1286 +/- ## ========================================== - Coverage 92.68% 91.36% -1.33% ========================================== Files 38 82 +44 Lines 2953 6482 +3529 ========================================== + Hits 2737 5922 +3185 - Misses 216 560 +344 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1286/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/1286/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `91.36% <ø> (-1.33%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ivirshup commented 1 month ago

Just touched base with Nikhil, this PR still needs some work.

Interestingly this will still drop cookies so maybe we should look back into readthedocs if cookies can be okay sometimes.

kaloster commented 1 month ago

@ivirshup Please take another look - added doNotTrack cookie as well - as defined here and also as outlined here