Closed pablo-gar closed 11 months ago
@pablo-gar I think we agreed this shouldn't be high priority. That said, it's almost no work...
Should we run the R tests on a nightly basis as well? Does the tiledbsoma r-universe dependency get pinned at build time or user installation time? If the latter, then we should.
Should we run the R tests on a nightly basis as well? Does the tiledbsoma r-universe dependency get pinned at build time or user installation time? If the latter, then we should.
Pablo responds:
R-universe makes everything a little confusing (imo). But generally speaking as far as I know R API grabs the latests versions of its uninstalled dependencies at time of installation. This means that: For a complete clean environment, it will get all the latests dependency versions at installation time. For an existing environment, at time of installation it will use the existing installed dependencies unless the user opts-in for updating dependencies, if there are uninstalled dependencies it will grab the latest as described above. And @mlin included in the CI to test for both: Fresh environment recreating user journey as described in 1) above. Fresh environment recreating development installation — latest tiledbsoma installation from main github branch https://github.com/chanzuckerberg/cellxgene-census/blob/main/.github/workflows/r-check.yml (edited)
@pablo-gar I think we agreed this shouldn't be high priority. That said, it's almost no work...
I see it as high priority but I did not consider it a blocker for our last release.
@pablo-gar - AFAIK, this is complete. Can you close if you and @mlin agree?
Agreed! @mlin ?
Closing this, as it appears all necessary changes have landed
We want to ensure that any patch-level updates to TileDB-SOMA will be readily tested against the Census API, to catch potential regressions. This will allow the TileDB-SOMA package dependency to more confidently use a fuzzy version pin for the patch level. E.g.
tiledbsoma~=1.4.0
.Schedule the Python unit tests GHA workflow and R unit tests GHA workflow to run on a nightly schedule
Notes:
tiledbsoma
. We only need to ensure the latest patch, as of "today", is working correctly. (Also, we do not expect > 1 patch level TileDB-SOMA release per day, sou nightly testing should suffice.)Ticket can be closed when work is completed for the builds of: