chanzuckerberg / cellxgene-census

CZ CELLxGENE Discover Census
https://chanzuckerberg.github.io/cellxgene-census/
MIT License
79 stars 20 forks source link

[python] remove deprecated X_sparse_iter API #962

Closed bkmartinjr closed 7 months ago

bkmartinjr commented 7 months ago

Fixes #832

Remove the API cellxgene_census.experimental.util.X_sparse_iter which has been replaced by SOMA blockwise iterators.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (67982f1) 86.17% compared to head (8a4ecfc) 86.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #962 +/- ## ========================================== - Coverage 86.17% 86.03% -0.15% ========================================== Files 74 71 -3 Lines 5723 5648 -75 ========================================== - Hits 4932 4859 -73 + Misses 791 789 -2 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/962/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-census/pull/962/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `86.03% <ø> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bkmartinjr commented 7 months ago

We already noted it as deprecated in the release notes and docstrings. I am comfortable just deleting it