feat: integrate with portal - Githubissues

chanzuckerberg / cellxgene-ontology-guide

Notebook guide: https://github.com/chanzuckerberg/cellxgene-ontology-guide/blob/main/api/python/notebooks/Python%20API.ipynb

https://chanzuckerberg.github.io/cellxgene-ontology-guide/

MIT License

4 stars 1 forks source link

feat: integrate with portal #103

Closed Bento007 closed 6 months ago

Bento007 commented 7 months ago

Approach

[ ] remove compute_tissue_and_cell_type_mappings.py
[ ] direct frontend to download descendant mappings from cellxgene-ontology-main into frontend/src/components/common/Filter/descendant_mappings
[ ] these s3 assets are not longer need.
[ ] refactor backend/common/utils/ontology_mappings to use ontology-guide
[ ] verify https://github.com/chanzuckerberg/single-cell-data-portal/issues/6227 is addressed

Testing Plan

A branch will be deploy to rdev, prod will be mirrored to this deployment, and a side by side comparison of filters and index endpoint will be done.
e2e test pass.

Definition of Done

Verify that the frontend filters work as expected
Verify that the dataportal index endpoint returns the correct response and is not too slow
Verify the assets from COG are updated when redeploying the portal.

nayib-jose-gloria commented 7 months ago

Integrating with Portal Draft PR: https://github.com/chanzuckerberg/single-cell-data-portal/pull/6788

Bento007 commented 6 months ago

A branch will be deploy to rdev, prod will be mirrored to this deployment, and a side by side comparison of filters and index endpoint will be done.

There were differences between the frontend filters, but they were improvements from the original.