codecov[bot]
commented
5 months ago Codecov Report
Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 85.29%. Comparing base (
96c7213) to head (9fa457c).:exclamation: Current head 9fa457c differs from pull request most recent head 068bc78. Consider uploading reports for the commit 068bc78 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ...ols/ontology-builder/src/all_ontology_generator.py | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #196 +/- ## ======================================= Coverage 85.29% 85.29% ======================================= Files 19 19 Lines 1095 1095 Branches 210 210 ======================================= Hits 934 934 Misses 151 151 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/chanzuckerberg/cellxgene-ontology-guide/pull/196/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/chanzuckerberg/cellxgene-ontology-guide/pull/196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg) | `85.29% <95.65%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chanzuckerberg#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reason for Change
Census currently uses x.x.x for encoding the CxG dataset schema version, e.g. 5.0.0 whereas the service uses vx.x.x e.g. v5.0.0 I think we should probably update the ontology service to adopt the Census semantics since there are plenty of Census data releases out there (which are immutable).
Changes
Testing steps
Notes for Reviewer
Updates to Ontology Files / ontology-processing (push) will fail until we release the API. It also doesn't need to run for this PR.