Closed Bento007 closed 2 months ago
"EFO:0022503": {
"ancestors": {
"EFO:0002888": 1,
"EFO:0001639": 2,
"EFO:0000001": 6
},
"label": "92-1",
"description": "Human uveal melanoma",
"synonyms": [
92.1
],
"deprecated": false
}
It looks like something that could easily be a typo. 92.1
could be converted to a string and then it will work fine.
Not commenting on the typing, but it looks like EFO is adding cell lines?
Typed as decimal?
<oboInOwl:hasExactSynonym rdf:datatype="http://www.w3.org/2001/XMLSchema#decimal">92.1</oboInOwl:hasExactSynonym>
It's being parsed into a float in python
"EFO:0022503": { "ancestors": { "EFO:0002888": 1, "EFO:0001639": 2, "EFO:0000001": 6 }, "label": "92-1", "description": "Human uveal melanoma", "synonyms": [ 92.1 ], "deprecated": false }
It looks like something that could easily be a typo.
92.1
could be converted to a string and then it work work fine.
I think its probably safe to add a str cast in the builder for anything in synonym, label, description
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 85.26%. Comparing base (
1ba810e
) to head (6c11b71
).:exclamation: Current head 6c11b71 differs from pull request most recent head f11690e. Consider uploading reports for the commit f11690e to get more accurate results
Files | Patch % | Lines |
---|---|---|
...ols/ontology-builder/src/all_ontology_generator.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reason for Change