chanzuckerberg / cellxgene

An interactive explorer for single-cell transcriptomics data
https://chanzuckerberg.github.io/cellxgene/
MIT License
615 stars 116 forks source link

Design a new dataset for testing automation #1578

Open seve opened 4 years ago

seve commented 4 years ago

We would benefit from adding/replacing our current testing dataset(pbmc3k) with a deeper and more diverse dataset. This could be enhanced with a joining of multiple existing datasets that would stress our typing system as well. Would require a refactoring of our hard-coded values and snapshots.

Ideally this dataset would eliminate the need to bring non-annotation related tests into the e2eAnnotations.test.js testing file.

Rough to-do list:

Some cases that need to be covered by the updated dataset:

Feel free to comment more ideas and I'll add to the list!

signechambers1 commented 3 years ago

@seve @maniarathi is this still relevant? do you want to include as some part of https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell/44?

maniarathi commented 3 years ago

Good call! I added it to our smoketest epic!

signechambers1 commented 3 years ago

@maniarathi the smoke test epic is closed, ok to close this ticket?

maniarathi commented 3 years ago

Beefing up our set of valid-but-unusual datasets is still a thing we need to work on to be honest and we had to trim our efforts in testing due to time constraints. I'd like to keep this open because the ideas listed above are good, but I'm not sure when to get to it. I'd mark it as a P3.