chanzuckerberg / cellxgene

An interactive explorer for single-cell transcriptomics data
https://chanzuckerberg.github.io/cellxgene/
MIT License
622 stars 116 forks source link

add proper semver support to code base #1674

Open bkmartinjr opened 4 years ago

bkmartinjr commented 4 years ago

there are several places in the python code where a semver value is interpreted, parsed, compared, etc. They are all deficient in a number of ways and could be improved by moving to a more full-featured semver package:

This isn't urgent, but should get sorted out so that various subsystems (eg, schema versioning, CXG versioning) can move forward in a more predictable and controlled manner.

signechambers1 commented 3 years ago

@maniarathi is this still something we should do? If so, let me know the priority. If not let's close.

maniarathi commented 3 years ago

Yeah -- this would still be valuable to do as we increase the number of versioned things in our system. Priority would be P2 imo.

roaga commented 2 years ago

I'm looking into this issue now, but it looks like cxgtool.py and cxg_adaptor.py no longer exist and upgrade.py seems to have a lot of semver logic already. Is this issue still a problem, and if so, in which files?