jgadling
commented
1 month ago deposition key photos have a deposition parent, and dataset key photos have depositions and datasets as parents, so if we have a config that specifies multiple depositions or mutliple datasets, those filters would be valid.
In practice we're not really using these config files to represent multiple depositions, and if we're ingesting keyphotos, we're typically only ingesting a single dataset, but we should probably document that it's possible to use the filters.
A couple questions (related, but not blockers):
Since this reflects dataset_keyphotos, can either of these realistically have a parent_filters? Or anything other than a literal (source_glob, destination_glob, etc.)? Whatever the answers might be, I just wanted to also confirm these changes are reflected in dataset_key_photo.py. Thanks!