search

chanzuckerberg / cryoet-data-portal

CryoET Data Portal
MIT License
19 stars 10 forks source link

Update oriented point rendering in neuroglancer #1059

Open manasaV3 opened 3 months ago

manasaV3 commented 3 months ago

Motivation

At present, Neuroglancer renders oriented points in the same manner as simple points, without incorporating the rotation vector component into the visualization. This potentially results in users only getting partial information from the visualization. This can be improved by adding the direction vector to the visualization.

The metacell team has updated the cryoet's neuroglancer repository with components for rending the orientation. This can be used for updating the existing visualization components.

Definition of Done

The oriented points are rendered in neuroglancer with rotational vectors.

Tasks

1. Integrate the new the precompute method for oriented point

The visualization precompute importer (ref: here) needs to be updated with changes (if required) to incorporate the oriented points visualization.

The method for generating the precompute (ref: here) maintains the existing signature, with an additional parameter of a default value. The integration needs to sanity check that the precomputation creates valid output objects of sharded precomputed data that can be rendered by neuroglancer.

2. Update the config layer generation

The visualization config importer (ref: here) needs to be updated with if required for the oriented points visualizations.

The method for generating the oriented point layer in neuroglancer (ref: here) should be integrated and validated to ensure it generates config that reflects the newer visualization

3. Regenerate the related components

Regenerate the annotation precomputes and neuroglancer config generations for all runs that have oriented point annotations.

4. Update Production

Sync data to production bucket after validating the data in staging, and update the neuroglancer field in tomogram table for datasets with oriented point annotaions.

Related PRs

https://github.com/chanzuckerberg/cryoet-data-portal-neuroglancer/pull/13

junxini commented 3 months ago

@manasaV3 + @Bento007 to help with pointing

manasaV3 commented 2 months ago

Related https://github.com/chanzuckerberg/cryoet-data-portal-neuroglancer/issues/18

manasaV3 commented 2 months ago

@Bento007 Let me know if more information is needed for pointing this. :)

junxini commented 2 months ago

this ticket will be to double check Metacell's solution recommendation

manasaV3 commented 2 months ago

This issue should fix the bug raised in: https://github.com/chanzuckerberg/cryoet-data-portal-neuroglancer/issues/18