chanzuckerberg / cryoet-data-portal

CryoET Data Portal
MIT License
20 stars 11 forks source link

Annotations sections in Download modal is showing up when opening it from Tomograms table #1293

Open lauramarcos opened 1 month ago

lauramarcos commented 1 month ago

Describe the bug Annotations text in Download modal should not be displayed when opening it from Tomograms table

To Reproduce Steps to reproduce the behavior:

  1. Go to https://cryoetdataportal.czscience.com/runs/364?table-tab=Tomograms
  2. Click on Download link in tomograms table
  3. See error

Screenshots

https://github.com/user-attachments/assets/dcc07166-27bb-4f86-93c3-2ee677968182

Desktop (please complete the following information):

junxini commented 3 weeks ago

@Janeece i left a comment in the designs to confirm. it does seem out of place to download all annotations when we're specifically clicking to download a single tomogram

Janeece commented 2 weeks ago

RE reported bug: Implementation is correct -- this was an in-flight change to address not having standardized annotations, sorry it wasnt (design change is here). The callout text aligned on by the team was universal for all download options (excluding "download dataset").

Please note that the original design's section cover sheet was labeled "archived" and a link to the new design is linked.

@Janeece i left a comment in the designs to confirm. it does seem out of place to download all annotations when we're specifically clicking to download a single tomogram

@junxini I think this is different than the reported bug? As i understand, the bug is about the callout text. Your comment seems to be about our approach to use the existing download flow instead of creating a separate flow for downloading individual tomograms from table — happy to discuss why we went this route and if we should log a design request ticket if thats the case!