chanzuckerberg / cryoet-data-portal

CryoET Data Portal

MIT License

16 stars 9 forks source link

chore: download dialog code snippet #794

Closed codemonkey800 closed 3 months ago

codemonkey800 commented 3 months ago

447

792

Add dedent package to convert code from React nodes to strings
Adds class name for code box
Adds code snippets for dataset and download all annotations

Demos

Download dataset

Download tomogram

Download all annotations

Download annotation

manasaV3 commented 3 months ago

For the tomogram download, do we have a screenshot for zarr file? Similarly, for the single annotation download, do we have a screenshot for the zarr and ndjson files?

Otherwise these look good to me.

codemonkey800 commented 3 months ago

@manasaV3 ooh sorry I missed those, adding them here:

For the tomogram download, do we have a screenshot for zarr file?

Similarly, for the single annotation download, do we have a screenshot for the zarr and ndjson files?

codemonkey800 commented 3 months ago

code-wise LGTM, design-wise are we using any syntax highlighting?

don't think I saw syntax highlighting in the original designs, but would be nice to have 😆 @Janeece could you confirm please?

Janeece commented 3 months ago

code-wise LGTM, design-wise are we using any syntax highlighting?

don't think I saw syntax highlighting in the original designs, but would be nice to have 😆 @Janeece could you confirm please?

Syntax highlighting would be very nice! Design doesn't have any established recommendations for colors (or bandwidth to make some), but I'm open to using one someone else has defined.

manasaV3 commented 3 months ago

the code snippets look good to me.

codemonkey800 commented 3 months ago

@kne42 @Janeece I opened up a separate issue for syntax highlighting for now, would love to get this in some day 🤩