search

chanzuckerberg / cryoet-data-portal

CryoET Data Portal
MIT License
12 stars 8 forks source link

ci: fix skip slack notify if condition #817

Closed codemonkey800 closed 1 week ago

codemonkey800 commented 1 week ago

811 fixes an issue with slack notify not being skipped when the release PR doesn't exist, but it only partially fixes the issue. even though the payload step is skipped, the notify slack step is not skipped

rather than add an additional condition on the notify slack step, we can skip the job altogether by updating the conditional. instead of always running via always(), the job will now only run if:

  1. the release PR exists
  2. the workflow succeeds or fails, cancels are skipped