chanzuckerberg / edu-design-system

Design system for Education Projects
https://chanzuckerberg.github.io/edu-design-system/
MIT License
29 stars 4 forks source link

fix(Checkbox): specify a font size for the checked glyph #2030

Closed booc0mtaco closed 1 month ago

booc0mtaco commented 1 month ago

Specify a font-size for the glyph in the checkbox so that wrapping adjacent text doesn't change the size of the glyph when :checked

Test Plan:

Before:

Screenshot 2024-08-08 at 17 16 24

After:

Screenshot 2024-08-08 at 17 16 29
github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
components 89.26 KB (0%)
styles 27.68 KB (+0.13% 🔺)
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.43%. Comparing base (2ad7b4c) to head (4c93c92).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2030 +/- ## ======================================= Coverage 97.43% 97.43% ======================================= Files 109 109 Lines 2608 2608 Branches 664 664 ======================================= Hits 2541 2541 Misses 65 65 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.