chanzuckerberg / edu-design-system

Design system for Education Projects
https://chanzuckerberg.github.io/edu-design-system/
MIT License
29 stars 4 forks source link

fix(Link): handle inverse variant for standalone links #2042

Closed booc0mtaco closed 1 month ago

booc0mtaco commented 1 month ago

Test Plan:

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
components 89.26 KB (+0.09% 🔺)
styles 27.27 KB (+0.06% 🔺)
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.43%. Comparing base (d6ee15d) to head (c110454). Report is 3 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2042 +/- ## ======================================= Coverage 97.43% 97.43% ======================================= Files 109 109 Lines 2613 2615 +2 Branches 664 665 +1 ======================================= + Hits 2546 2548 +2 Misses 65 65 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

booc0mtaco commented 1 month ago

Fix here is to make cases where we have standalone links with default variant appear with the correct color

https://61313967cde49b003ae2a860-xiicuaigmu.chromatic.com/?path=/story/components-link--standalone-inverse-variant