chanzuckerberg / galago

Interpretation aids for genomic epidemiology
https://chanzuckerberg.github.io/galago/
MIT License
8 stars 3 forks source link

General Questions/Feedback and a text update WRT ClusterTracker/matUtils #130

Closed jmcbroome closed 2 years ago

jmcbroome commented 2 years ago

Hi Sidney- I played around some with your demo and a local development server version of Galago and have a handful of points of feedback/questions. I also have a small text edit proposed here, specifically with regards to the matUtils cluster method, clarifying what the method is and linking my recently published manuscript on it to reference for more information.

Additional feedback/questions:

Let me know your thoughts and if there's anything I could assist with!

sidneymbell commented 2 years ago

Thank you so much for the feedback and PR, @jmcbroome ! Left a small code suggestion (just making it a bit shorter for space). LMK what you think.

Re: your other questions --

  1. Yes, I agree! I'm actually about to push a nice cluster diagram (i.e., an unrooted subtree with a few visual tweaks to help it feel more familiar to epi folks). I'd love your feedback once it's live!

  2. I also worry about sampling bias quite a bit. The hard thing in this case is that we don't know anything about the data coming in -- e.g., they may well have already done their own downsampling, or they may have selected specific samples to include based on who they're trying to do contact tracing for. If you have any ideas on how to make the sampling bias information more interpretable or visible, I'd love to hear! :)

  3. This feedback on the workflow is gold! We're in the midst of a design audit, I'll make sure to pass this along to our UI designers. To clarify: are you talking about the controls under the "case definition" section?

sidneymbell commented 2 years ago

cc @happyimadesignr

jmcbroome commented 2 years ago

RE Point 1, let me know once it's live and I'll check it out! I reference timetree specifically so that it can appear in line with your existing graph, though if its unrooted I suppose that doesn't apply.

RE Point 2, it's possible to remove samples that are identical to other samples and collected from the same region at about the same time, at the most basic level, which is pretty safe. You could even replace these samples with a number of condensed or collapsed samples on your tree visual, potentially... definitely could use some more thought.

RE Point 3, I mean the panel that appears when "Filter and Suggest Clades" is clicked, where the text edit I proposed is and so on, if that's what you're referring to.