search

chanzuckerberg / galago

Interpretation aids for genomic epidemiology
https://chanzuckerberg.github.io/galago/
MIT License
8 stars 2 forks source link

Handle changes around custom domain #177

Closed vincent-czi closed 2 years ago

vincent-czi commented 2 years ago

IMPORTANT NOTE Do NOT merge this until the custom domain CNAME stuff is set up in the genepi infra, otherwise the prod site will go down due to the path changes.

This is mostly intended to incorporate the work from this PR to handle switching over to GitHub Pages using a custom domain: https://github.com/chanzuckerberg/galago-labs/pull/4

However, I'm also seeing some surprising merge conflicts between the two repos? I'm not sure why yet. This handles that merge conflict, but I'm a bit worried we're going to keep seeing this every time we need to move code from the galago-labs repo to the prod galago repo... Previously, I think I directly pushed to galago/main, so it's possible without a PR across forks GitHub doesn't do a great job of incorporating new commits even if -- as far as I can tell -- it shouldn't have triggered a merge conflict. Honestly, I'm kind of grasping at straws. Hopefully I just did cause a real merge conflict and didn't notice. But we might have to watch out for this and figure out the problem if it keeps happening.

vincent-czi commented 2 years ago

Custom domain CNAME stuff in place! Let's goooooo