chanzuckerberg / galago

Interpretation aids for genomic epidemiology
https://chanzuckerberg.github.io/galago/
MIT License
8 stars 2 forks source link

[Bug] Visual issues around fetch error message and long fetch URLs #199

Closed vincent-czi closed 1 year ago

vincent-czi commented 1 year ago

Describe the bug A very long URL being fetched that fails writes out of the edge of the warning.

Expected behavior Not obvious what expected behavior should be, but it looks weird to have it go out of the bounding box of the error.

To Reproduce Steps to reproduce the behavior:

  1. Do a "fetch" on a very long URL that is not real, eg http://localhost:3000/#/fetch/lorem.com/ipsumdolorsitametconsecteturadipisicingelitseddoeiusmodtemporincididuntutlaboreetdoloremagnaaliquaUtenimadminimveniamquisnostrudexercitationullamcolaborisnisiutaliquipexeacommodoconsequat
  2. Look at error box

Screenshots

image

x to close is way past rest of page content

image

Additional context While this is purely a visual thing, the data is still there, when these fetches go wrong they will usually have very long URLs. Most of the auto-generated hand off URLs for this sort of interaction are very long. But it's very much a nice-to-have since user can still get the info.

sidneymbell commented 1 year ago

Woof. Thanks, Vincent (somehow I just realized I have not been getting notifications for newly filed issues, sorry for the delayed response!).

Since we've removed the URL from the error message for now, I'm going to close this for the time being. I'll definitely keep it in mind if we return to providing the URL (which would be nice)