chanzuckerberg / galago

Interpretation aids for genomic epidemiology
https://chanzuckerberg.github.io/galago/
MIT License
8 stars 3 forks source link

Add URL-based API for taking in JSON #2

Closed sidneymbell closed 2 years ago

sidneymbell commented 2 years ago

Similar to nextstrain.org/fetch/URL

sidneymbell commented 2 years ago

Thanks to @jacoblerner-czi for consulting on this ticket from a security standpoint! Takeaways:

sidneymbell commented 2 years ago

Requirements and pointers on where to start (cc @oliviabholmes to add / adjust) --

oliviabholmes commented 2 years ago

@sidneymbell how are we currently ingesting JSON? Trying to understand why this is a blocker

sidneymbell commented 2 years ago

@oliviabholmes -- currently via direct upload

It's a blocker because it's required to take in data from CZ GEN EPI via the planned integration, which uses the same pre-signed URLs for trees that we use to link out to nextstrain.

sidneymbell commented 2 years ago

Related to #145 and #147

Notes from @vincent-czi --

sidneymbell commented 2 years ago

Status update: fetch is working for JSON and URL

Propose splitting the ticket to add the query params late next week (technically after launch).

vincent-czi commented 2 years ago

Closed as main chunk of work -- taking in the external URL JSON -- is complete. Follow up work for doing query / search params filed as #186