start phasing out aws_region and deployment_env inputs

chanzuckerberg / idseq-workflows

Portable WDL workflows for IDseq production pipelines

https://idseq.net/

MIT License

31 stars 12 forks source link

start phasing out aws_region and deployment_env inputs #5

Closed mlin closed 4 years ago

mlin commented 4 years ago

@kislyuk proposing this way to phase out the aws_region and deployment_env inputs, which 'should' already be unnecessary, but something could still go wrong of course. Making them optional, so we can take them out of the inputs and later when we're satisfied they're no longer needed, delete them entirely.

The interpolation uses a WDL trick which evaluates ~{"foo" + x} to the empty string if x is null.

kislyuk commented 4 years ago

Oh... I just pushed a branch that just deleted all occurrences of region and deployment_env. I don't see the need to tiptoe around it, IMHO we should get rid of them all and catch any issues in test.

kislyuk commented 4 years ago

Hoping this isn't too flippant but I mean, this PR is adding lines where we are aiming to remove them :)

mlin commented 4 years ago

@kislyuk Sure, I defer to your estimation of whether we'll need some transition period as we build out the unit test suite (which we should endeavor to make run without the non-portable plugin behaviors). I'm not really familiar with what/how things break without these env vars.

kislyuk commented 4 years ago

AWS_REGION can be set from the metadata supplied by ECS
DEPLOYMENT_ENVIRONMENT is only used by remote non-host alignment, and will not be needed if that step is run locally

kislyuk commented 4 years ago

Independently addressed in #6.