chanzuckerberg / idseq-workflows

Portable WDL workflows for IDseq production pipelines
https://idseq.net/
MIT License
31 stars 12 forks source link

Updates to address gaps identified in initial ont validation #89

Closed katrinakalantar closed 3 years ago

katrinakalantar commented 3 years ago

Summary During validation of the ONT nanopore pipeline, there were a few issues that were identified. This PR resolves those issues as well as modifying some of the default parameters to ensure quality of genomes generated by the ONT nanopore pipeline matches the quality of existing genomes submitted to public data repositories.

Issues Addressed

Parameters Updated

Integration Testing After these updates were implemented, seven ONT Artic v3 datasets obtained from SRA were run through the ONT pipeline and benchmarked against their final GISAID genomes. The results obtained by this pipeline were identical to those uploaded to GISAID (with the exception of a few samples where uploaded genomes contained 2 Ns that were now called as reference), all samples passed VADR checks and looked good when QC-checked in NextClade.

kislyuk commented 3 years ago

Approved pending minor changes.